Interested Developer

Hey, I just found out about this and I'm interested in developing. I grabbed the source and started looking through it, but the sourceforge page is somewhat...lacking. Is there a list of known bugs somewhere, or anything of that nature?

Re: Interested Developer

Hooray! Thanks for the help. I guess we should use the bug tracking system more, but I don't know how often any of us actually check Sourceforge. :)

Known bugs:

* color bug on mac/linux (more info) - I'm going to look at it once my desktop machine is up and running again (soon)

* gui glitch with sliders

* unit placing bug

* magic goddess bug

Any others, Harvy? These are the ones that I could dig up on the forums.

Re: Interested Developer

The code on my computer has a bunch of minor fixes/changes that I haven't committed because I'm not connected to the internet... including a possible fix for the slider glitch.

I did have a few other things to work on:

* Save / load seems to work for network games, but not for offline games, which is a nuisance. I think the problem is how Invade Earth "remembers" the moves previously made during a game; the extra synchronization controls in network games keep things steady (but not for non-network games).

* AI sometimes places on plagues (should be easy to fix).
* AI sometimes makes empty free moves. This is only a problem because the game rules ignore empty free moves to make it harder for human players to waste free moves. It doesn't freeze the game, because the AI only makes a move 99% of the time (so eventually it gives up and ends its turn) but it can stall it noticably and is generally annoying. This shouldn't be too hard to fix either.

If you give me your Sourceforge username I can add you to the list to commit changes.

Re: Interested Developer

Sourceforge username: reedkc

Re: Interested Developer

OK, you should be able to commit to the CVS.

I recommend you use NetBeans, since the CVS has project information in their format. We generally communicate through the Smiley Pro forums and ignore Sourceforge (except for CVS and hosting of Invade Earth builds).

Re: Interested Developer

* "Fire Rains Down" card fails to destroy the temple in the selected territory, though it does destroy the armies as it is supposed to

Re: Interested Developer

Finally got some free time. I started off light and fixed the placing troops on plagues problem, and the empty free moves. By the way, did you guys care that sometimes (albeit rarely), it's probably correct to throw some guys on a plagued territory? Ruling it out entirely kills that, but it doesn't seem like you're too strict on the AI shoulds and shouldn'ts. I haven't checked anything in yet.

Re: Interested Developer

Fixed Fire Rains Down. Was missing this line: territory.getForce().getSpecialUnits().remove(GodstormRules.TEMPLE);

Fixed a typo in Paradise Is Lost description.

Will probably do a check-in later tonight unless you guys have some type of code review shenanigans.

Edit: Fixed Magic Goddess labor bug; assuming we're all cool with the simple and less-busted ruling that the hasTriple check is made after 1's have been rerolled. Yeah, it's technically supposed to run the triple check every time three dice hit the table, but in the case of rerolling, that's just silly.

Re: Interested Developer

Thanks a lot! I don't think there's anything special with code review (since we have so few developers), so commit at your leisure. :)

Re: Interested Developer

Sounds awesome. The "code review" is that if you release a broken version people will be mad at you instead of me ;)

Go to the About class and add your name to the list as a developer. Also in the big InvadeEarth class increment the small version number. (Version numbering is pretty arbitrary.)

The AI isn't so powerful that something like placing on plagues would ever make sense. You could tell it to never place more than 1 or 2 armies (no "special units) on a plague, but it's also ok to never place on plagues.